RFR: JDK-8302599: Extend ASan support to Microsoft Visual C++ [v2]

Magnus Ihse Bursie ihse at openjdk.org
Sat Feb 18 21:34:28 UTC 2023


On Sat, 18 Feb 2023 18:03:32 GMT, Justin King <jcking at openjdk.org> wrote:

>> make/autoconf/jdk-options.m4 line 427:
>> 
>>> 425:       ],
>>> 426:       IF_ENABLED: [
>>> 427:         ASAN_CFLAGS="-fsanitize=address"
>> 
>> It seems like more of a coincidence than a obvious fact to base the design on that `-fsanitize=address` happens to work on both ms cl.exe and gcc/clang.
>> 
>> Maybe this is the herald of a new age of compiler switches getting cross-compiler standard names (let's hope!), but I think it still makes more sense to not share CFLAGS between microsoft and clang/gcc.
>> 
>> Or, more concretely: There is no need to define `ASAN_CFLAGS` and `ASAN_LDFLAGS` outside the two toolchain specific clauses.
>
> Updated to what I think you were requesting. PTAL.

Yes, indeed. Thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/12580



More information about the build-dev mailing list