RFR: 8302659: Modernize Windows native code for NetworkInterface [v2]
Rich DiCroce
duke at openjdk.org
Wed Feb 22 17:40:34 UTC 2023
On Fri, 17 Feb 2023 10:37:30 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:
>> Rich DiCroce has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Limit line length to 80-ish characters
>
> I don't think the NetworkInterface.h file should be dropped.
> It is preferrable that typedef and struct decalarations remain in a header file rather than being merged into .c file.
@msheppar I've moved the struct declaration back to the .h file.
The full jdk_net suite passes on my machine.
-------------
PR: https://git.openjdk.org/jdk/pull/12593
More information about the build-dev
mailing list