RFR: 8303131: pandoc.exe mangles all processed html files

Julian Waters jwaters at openjdk.org
Fri Feb 24 08:52:18 UTC 2023


On Thu, 23 Feb 2023 21:01:52 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> pandoc.exe follows the Windows CRLF format of newlines, whereas we only ever have LF in our documentation files. As a result whenever we generate html the resulting html files will all be mangled, even if there was no change to the corresponding markdown file. This passes --eol=lf to pandoc so that it always uses LF no matter the platform, since we never ever seem to use (or even want to use) CRLF at all, so that pandoc will exhibit consistent behaviour on all platforms
>> 
>> pandoc by default uses the --eol=native option, which is LF on macOS, Linux and UNIX, so this change will not affect their html generation whatsoever, but will make the lives of Windows JDK developers and _especially_ JDK developers working with MSYS2 a hell of a lot easier (*cries internally)
>
> Marked as reviewed by erikj (Reviewer).

Thanks for the review @erikj79!

-------------

PR: https://git.openjdk.org/jdk/pull/12733



More information about the build-dev mailing list