RFR: 8301119: Support for GB18030-2022 [v3]
Ichiroh Takiguchi
itakiguchi at openjdk.org
Sun Feb 26 04:39:17 UTC 2023
On Fri, 24 Feb 2023 17:19:22 GMT, Naoto Sato <naoto at openjdk.org> wrote:
>> Hello @naotoj .
>> Sorry for bothering you.
>>
>> I have following question:
>> - Why GB18030.java.template is in src/jdk.charsets/share/classes/sun/nio/cs/ext/ directory even if the generated code is always stored into sun/nio/cs ?
>> I think the file should be moved to src/java.base/share/classes/sun/nio/cs and the file name should be GB18030.java instead of GB18030.java.template.
>> Is there specific reason ?
>
>> Hello @naotoj . Sorry for bothering you.
>>
>> I have following question:
>>
>> * Why GB18030.java.template is in src/jdk.charsets/share/classes/sun/nio/cs/ext/ directory even if the generated code is always stored into sun/nio/cs ?
>> I think the file should be moved to src/java.base/share/classes/sun/nio/cs and the file name should be GB18030.java instead of GB18030.java.template.
>> Is there specific reason ?
>
> No, there is not. Thanks for pointing it out. Fixed.
Thanks @naotoj .
That's what I expected.
-------------
PR: https://git.openjdk.org/jdk/pull/12518
More information about the build-dev
mailing list