RFR: 8294982: Implementation of Classfile API [v20]

Adam Sotona asotona at openjdk.org
Mon Feb 27 13:38:42 UTC 2023


On Thu, 16 Feb 2023 11:21:29 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/components/CodeLocalsShifter.java line 43:
> 
>> 41: 
>> 42: /**
>> 43:  * CodeLocalsShifter is a {@link jdk.internal.classfile.CodeTransform} shifting locals to
> 
> Missing `{@code}` (here and elsewhere)

fixed, thanks.

> src/java.base/share/classes/jdk/internal/classfile/components/CodeStackTracker.java line 53:
> 
>> 51:  *         trackedBuilder.aload(0);
>> 52:  *         trackedBuilder.lconst_0();
>> 53:  *         trackedBuilder.ifThen(...
> 
> missing closed parens?

fixed, thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/10982



More information about the build-dev mailing list