RFR: 8294982: Implementation of Classfile API [v20]

[Adam Sotona]

On Thu, 16 Feb 2023 14:47:52 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/impl/InstructionData.java line 47:
> 
>> 45:  * InstructionData
>> 46:  */
>> 47: public class InstructionData {
> 
> As CodeImpl seems to be the only client of this, I wonder if we could move the static cache in there?

yes, will fix it

> src/java.base/share/classes/jdk/internal/classfile/impl/LabelImpl.java line 65:
> 
>> 63: 
>> 64:     public int getContextInfo() {
>> 65:         return contextInfo;
> 
> This seems to be the BCI - should we change names to reflect that? (`contextInfo` seems very vague)

yes, will fix it

-------------

PR: https://git.openjdk.org/jdk/pull/10982