RFR: 8299330: Workflows should not install MSYS2 in the JDK's source directory [v7]

Aleksey Shipilev shade at openjdk.org
Tue Jan 3 10:11:49 UTC 2023


On Wed, 28 Dec 2022 16:12:06 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> MSYS2 should be more appropriately installed into the runner's temporary directory rather than inside the newly checked out repository containing all the JDK's source code, as doing so may interfere with the build process and cause weird corner cases in the submitted actions workflow
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Formatting
>  - Directory reference
>  - Avoid installing MSYS2 in the JDK's source directory

I don't quite understand what is the issue here. We do drop quite a bit of things in the OpenJDK root: bootjdk, gtest, jtreg, etc. How is msys2 different here? I would be more concerned about depleting the tmp space on the runner after this patch.

-------------

PR: https://git.openjdk.org/jdk/pull/11782



More information about the build-dev mailing list