RFR: JDK-8298908: Instrument Metaspace for ASan [v12]

Thomas Stuefe stuefe at openjdk.org
Thu Jan 12 07:43:18 UTC 2023


On Thu, 12 Jan 2023 05:44:55 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update sanitizers/address.h based on review
>>   
>>   Signed-off-by: Justin King <jcking at google.com>
>
> src/hotspot/share/memory/metaspace/chunkManager.cpp line 308:
> 
>> 306:   }
>> 307: 
>> 308:   if (enlarged) {
> 
> What's the reason of calling the ASAN functions outside of the lock?
> 
> Will we have a race condition if two threads call ChunkManager::attempt_enlarge_chunk() at the same time and get to here out of order? @tstuefe

To be enlarged chunk belongs to the class loader already, and we are inside the class loader metaspace lock.

-------------

PR: https://git.openjdk.org/jdk/pull/11702



More information about the build-dev mailing list