RFR: 8294982: Implementation of Classfile API [v7]

Magnus Ihse Bursie ihse at openjdk.org
Thu Jan 12 12:50:20 UTC 2023


On Fri, 16 Dec 2022 18:22:24 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> This is root pull request with Classfile API implementation, tests and benchmarks initial drop into JDK.
>> 
>> Following pull requests consolidating JDK class files parsing, generating, and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) will chain to this one.
>> 
>> Classfile API development is tracked at:
>> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-branch
>> 
>> Development branch of consolidated JDK class files parsing, generating, and transforming is at:
>> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-dev-branch
>> 
>> Classfile API [JEP](https://bugs.openjdk.org/browse/JDK-8280389) and [online API documentation](https://htmlpreview.github.io/?https://raw.githubusercontent.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/java.base/jdk/classfile/package-summary.html) is also available.
>> 
>> Please take you time to review this non-trivial JDK addition.
>> 
>> Thank you,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - removal of Preview.java and TransPatterns.java patch
>    and enabled preview for java.base
>  - jdk.compiler ClassWriter patch to avoid writing PREVIEW_MINOR_VERSION to classes participating in preview

make/modules/java.base/Java.gmk line 28:

> 26: DOCLINT += -Xdoclint:all/protected \
> 27:     '-Xdoclint/package:java.*,javax.*'
> 28: JAVAC_FLAGS += -XDstringConcat=inline

I think it makes more sense to just have a single `JAVAC_FLAGS` assignment line, not one per flag.

-------------

PR: https://git.openjdk.org/jdk/pull/10982



More information about the build-dev mailing list