RFR: 8299330: Minor improvements in MSYS2 Workflow handling [v10]

[Julian Waters]

On Wed, 11 Jan 2023 12:09:42 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> MSYS2 should be more appropriately installed into the runner's temporary directory rather than inside the newly checked out repository containing all the JDK's source code, as doing so may interfere with the build process and cause weird corner cases in the submitted actions workflow. On windows, the bash it uses is also not run properly, which we should address
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into patch-2
>  - Install in RUNNER_TOOL_CACHE
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Merge branch 'openjdk:master' into patch-2
>  - Formatting
>  - Directory reference
>  - Avoid installing MSYS2 in the JDK's source directory

Aw :( Hope you're feeling better now at least

In any case, thanks for the review, I'll probably take the tar issue to build-dev so others can chip in, because I am at a loss as well. Will let the tests run and check the configure step on Windows one last time before integrating

-------------

PR: https://git.openjdk.org/jdk/pull/11782