RFR: 8146132: Excessive output from make test-image [v2]

Coleen Phillimore coleenp at openjdk.org
Fri Jan 13 15:12:46 UTC 2023


On Thu, 12 Jan 2023 18:01:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change makes native output files be only printed when building with LOG=info, to make the build not have so many pages of output.
>> Tested with GHA and locally (tbd)
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   This seems to do the right thing without summarizing the number of object files compiled for the tests.

The reason I'm picking on the test files and not the message Creating blah because of (1) file is because it has the logic in TestFilesCompilation.gmk compiles each individually.
Adding a message at the end of it like:

    +  $$(call LogWarn, Creating $$($1_OUTPUT_DIR)/support/ from $$(words \
    +               $$(filter-out %.vardeps, $$($1_FILTERED_FILE_LIST))) file(s))

comes out whether anything compiled or not, which nobody wants.
Unless you can pass status back from this 'foreach' loop.  I guess I'm stuck.

-------------

PR: https://git.openjdk.org/jdk/pull/11930



More information about the build-dev mailing list