RFR: 8300111: Add rpath for common lib locations for jpackageapplauncher
Alexey Semenyuk
asemenyuk at openjdk.org
Fri Jan 13 18:27:29 UTC 2023
On Tue, 10 Jan 2023 09:57:19 GMT, David <duke at openjdk.org> wrote:
> This patch adds the `-headerpad_max_install_names` linker argument to the build of the `jpackageapplauncher` binary (osx only)
>
> Adding this argument allows the user to use the `install_name_tool` to add search paths for the dynamic linker to the launcher binary. This is required for certain use cases where a native library loads other dynamic native libraries via `dlopen`.
>
> The change has been successfully tested on osx on aarch64:
>
> make jdk.jpackage
> install_name_tool -add_rpath @executable_path/../Frameworks/ jpackageapplauncher
> otool -l jpackageapplauncher
>
> Load command 19
> cmd LC_RPATH
> cmdsize 48
> path @executable_path/../Frameworks/ (offset 12)
Marked as reviewed by asemenyuk (Reviewer).
Looks good.
@magicus, @sashamatveev is the best to ask for macosx-related reviews in jpackage.
-------------
PR: https://git.openjdk.org/jdk/pull/11922
More information about the build-dev
mailing list