RFR: 8300169: Build failure with clang-15

Jie Fu jiefu at openjdk.org
Sat Jan 14 14:35:00 UTC 2023


Hi all,

Please review the fix for the build failure with clang-15.

1. -Wbitwise-instead-of-logical

   1) src/hotspot/share/oops/generateOopMap.cpp          <--- fixed the warning
   2) src/hotspot/share/runtime/notificationThread.cpp   <--- keep the code and disable warnings
   3) src/hotspot/share/runtime/serviceThread.cpp        <--- keep the code and disable warnings


2. -Wdeprecated-non-prototype (all the warnings are disabled)

   1) Mainly caused by files under `src/java.base/share/native/libzip/zlib/`  <--- keep the code and disable warnings
      It occurred while building LIBJLI, LIBZIP and LIBSPLASHSCREEN.

   2) While compiling src/java.desktop/share/native/libawt/awt/medialib/awt_ImagingLib.c  <--- keep the code and disable warnings

   3) Caused by src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m  <--- fixed the warnings


3. -Wdeprecated-builtins

   Caused by files under src/java.desktop/share/native/libharfbuzz/  <--- fixed the warnings

   Ref: https://github.com/harfbuzz/harfbuzz/blob/main/src/hb-meta.hh#L202

4. -Wgnu-folding-constant

   Caused by src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderer.m  <--- keep the code and disable warnings


Thanks.
Best regards,
Jie

-------------

Commit messages:
 - 8300169: Build failure with clang-15

Changes: https://git.openjdk.org/jdk/pull/12005/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12005&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8300169
  Stats: 15 lines in 6 files changed: 5 ins; 0 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/12005.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12005/head:pull/12005

PR: https://git.openjdk.org/jdk/pull/12005



More information about the build-dev mailing list