RFR: JDK-8300069: Left shift of negative value in share/adlc/dict2.cpp [v4]

[Magnus Ihse Bursie]

On Fri, 13 Jan 2023 16:01:55 GMT, Justin King <jcking at openjdk.org> wrote:

>> Refactor `hashstr` to use unsigned integrals to avoid undefined behavior.
>
> Justin King has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Resolve conflicts
>    
>    Signed-off-by: Justin King <jcking at google.com>
>  - Revert share/adlc/dict2.cpp changes
>    
>    Signed-off-by: Justin King <jcking at google.com>
>  - Silence undefined behavior checking for left hand side of shift
>    
>    Signed-off-by: Justin King <jcking at google.com>
>  - Left shift of negative value in share/adlc/dict2.cpp
>    
>    Signed-off-by: Justin King <jcking at google.com>

This looks good from a build perspective, but you need to get confirmation from hotspot folks that they accept this solution as well.

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11977