RFR: 8300806: Update googletest to v1.13.0 [v2]
Erik Joelsson
erikj at openjdk.org
Mon Jan 23 14:03:09 UTC 2023
On Sat, 21 Jan 2023 00:09:18 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:
>> Please review this PR which updates the required version of googletest to v1.13.0.
>>
>> It’s been (quite) a while since we upgraded the version of googletest used to run the hotspot unit tests (test/hotspot/gtest). The current version (1.8.1) is from 2018 and there is build issue with Xcode 14.x which has been resolved in more recent versions of googletest.
>>
>> The configure.ac file has been removed from googletest so the only file which contains the version is CMakeLists.txt, hence the removed logic from `make/autoconf/lib-tests.m4`.
>>
>> Testing: tier1, gtest:all, GHA
>
> Mikael Vidstedt has updated the pull request incrementally with one additional commit since the last revision:
>
> Update doc/building.html
Marked as reviewed by erikj (Reviewer).
-------------
PR: https://git.openjdk.org/jdk/pull/12125
More information about the build-dev
mailing list