RFR: 8300806: Update googletest to v1.13.0 [v4]
Mikael Vidstedt
mikael at openjdk.org
Mon Jan 23 20:47:32 UTC 2023
> Please review this PR which updates the required version of googletest to v1.13.0.
>
> It’s been (quite) a while since we upgraded the version of googletest used to run the hotspot unit tests (test/hotspot/gtest). The current version (1.8.1) is from 2018 and there is build issue with Xcode 14.x which has been resolved in more recent versions of googletest.
>
> The configure.ac file has been removed from googletest so the only file which contains the version is CMakeLists.txt, hence the removed logic from `make/autoconf/lib-tests.m4`.
>
> Testing: tier1, gtest:all, GHA
Mikael Vidstedt has updated the pull request incrementally with one additional commit since the last revision:
Update building docs to reflect new minimum gtest requirement
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/12125/files
- new: https://git.openjdk.org/jdk/pull/12125/files/5f8c67f7..e6da6245
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=12125&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=12125&range=02-03
Stats: 7 lines in 2 files changed: 1 ins; 0 del; 6 mod
Patch: https://git.openjdk.org/jdk/pull/12125.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/12125/head:pull/12125
PR: https://git.openjdk.org/jdk/pull/12125
More information about the build-dev
mailing list