RFR: 8300997: Add curl support to createJMHBundle.sh

Eirik Bjorsnos duke at openjdk.org
Wed Jan 25 12:40:05 UTC 2023


On Tue, 24 Jan 2023 13:45:37 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Please review this PR which updates make/devkit/createJMHBundle.sh to add support for curl instead of wget when downloading JMH dependencies.
>> 
>> This would reduce friction for MacOS devs who would like to run micros without installing wget first.
>> 
>> File download is extracted to a function taking the Maven directory, artifactId and version as input. The function builds the correct download URL and checks which of curl / wget is available.
>> 
>> Tested on MacOS 12.6.2 and Ubuntu 20.
>
> Filed https://bugs.openjdk.org/browse/JDK-8300997

@erikj79 Thanks for your review and help with the JBS, much appreciated!

Will you also be willing to sponsor?

-------------

PR: https://git.openjdk.org/jdk/pull/12164



More information about the build-dev mailing list