RFR: JDK-8300592: ASan build does not correctly propagate options to some test launchers [v2]

[Justin King]

On Wed, 25 Jan 2023 15:28:14 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Justin King has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove extra whitespace
>>    
>>    Signed-off-by: Justin King <jcking at google.com>
>>  - Always link ASan default options to any test launchers
>>    
>>    Signed-off-by: Justin King <jcking at google.com>
>
> make/common/TestFilesCompilation.gmk line 92:
> 
>> 90:         NAME := $$(unprefixed_name), \
>> 91:         TYPE := $$($1_COMPILATION_TYPE), \
>> 92:         EXTRA_FILES := $$(file) $$($1_EXTRA_FILES), \
> 
> Since you are adding a new argument to this function, can you just briefly document it in the list of arguments given at the top of the function (macro) definition?
> 
> (Sorry for the slow response; apart from this documentation issue, it looks good).

Done.

-------------

PR: https://git.openjdk.org/jdk/pull/12082