RFR: 8298424: Remove redundant FOUND_CORES variable in build-performance.m4
Amit Kumar
duke at openjdk.org
Mon Jan 30 14:10:16 UTC 2023
On Mon, 30 Jan 2023 13:52:48 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Beside any specific reason which I'm unaware of, IMO FOUND_CORES variable serves no purpose. So probably we could remove it, without any issue.
>>
>> Any suggestion/thoughts are appreciated :)
>
> There is one subtle change in behavior in this change. If one of the detection mechanisms was to find "0", it would get reverted to the default "1" and the warning would be printed. That's probably better behavior than actually setting it to "0".
Thanks @erikj79 for review. I'll integrate it now.
-------------
PR: https://git.openjdk.org/jdk/pull/12285
More information about the build-dev
mailing list