RFR: 8311541: JavaThread::print_jni_stack doesn't support native stacks on all platforms

David Holmes dholmes at openjdk.org
Thu Jul 13 07:48:41 UTC 2023


[JDK-8295974](https://bugs.openjdk.org/browse/JDK-8295974) modified print_jni_stack to print the native stack when there are no Java frames. To do that it used VMError::print_native_stack, however that function is only for platforms that support stack-walking by following frames, on other platforms (i.e. Windows and AIX) we need to use os::platform_print_native_stack.

I'm not trying to consolidate the different versions of the stack printing code in this PR so that it is more easily backported to where [JDK-8295974](https://bugs.openjdk.org/browse/JDK-8295974) was.

The test has been updated to work on Windows (taking advantage of two other recent enhancements - see JBS for details).

Testing:
- tiers 1-3 (sanity)
-  TestNativeStack regression test

Thanks

-------------

Commit messages:
 - Only save symbols on Windows - other platforms don't need it
 - Merge branch 'master' into 8311541-print-jni-stack
 - interim

Changes: https://git.openjdk.org/jdk/pull/14862/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14862&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8311541
  Stats: 51 lines in 5 files changed: 43 ins; 1 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/14862.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14862/head:pull/14862

PR: https://git.openjdk.org/jdk/pull/14862



More information about the build-dev mailing list