RFR: 8312882: Update the CONTRIBUTING.md with pointers to lifecycle of a PR

Jesse Glick duke at openjdk.org
Wed Jul 26 07:32:09 UTC 2023


On Thu, 29 Jun 2023 18:59:45 GMT, Jesse Glick <duke at openjdk.org> wrote:

> @jaikiran in https://github.com/openjdk/jdk/pull/12871#issuecomment-1612310113 pointed me to a resource I had not previously found. https://openjdk.org/contribute is fine at a high level but still says things like
> 
>> When your change is ready, send a message to the appropriate development list…
> 
> which clearly predates Skara, and does not apparently link to anything more current. Whereas this https://github.com/openjdk/jdk/blob/master/doc/building.md is thorough and discoverable, finding accurate guidelines for proposing pull requests was tough.

By the way the bots seem to contradict themselves:

> Commit message must refer to an issue

and a previous failing `jcheck-openjdk/jdk-14716` check run referred to a _commit_ message. Yet

> Please do not rebase or force-push to an active PR

implies that there would be no way to correct a mistaken commit message! Perhaps the bot messages should be adjusted to refer to the PR title, which I think is what they are actual checking, rather than “the commit message” (which is especially ambiguous if there are multiple commits).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14716#issuecomment-1650146616



More information about the build-dev mailing list