RFR: 8313082: Enable CreateCoredumpOnCrash for testing in makefiles [v2]

[David Holmes]

On Thu, 27 Jul 2023 04:02:00 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The option
>> CreateCoredumpOnCrash
>> is enabled by default except the Windows client systems with release binaries. 
>> 
>> So it makes sense to switch it on explicitly in makefiles on Windows while testing. It still could be redefined by adding '-XX-CreateCoredumpOnCrash' as jtreg -vmoption if needed.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed comment

Looks fine other than a minor typo.

Thanks

make/RunTests.gmk line 803:

> 801:   # If running on Windows, propagate the _NT_SYMBOL_PATH to enable
> 802:   # symbol lookup in hserr files
> 803:   # The mindumps are disabled by default on client Windows, so enable them

Typo: mindumps -> minidumps

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15050#pullrequestreview-1549155093
PR Review Comment: https://git.openjdk.org/jdk/pull/15050#discussion_r1275830698