RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v2]

David Holmes dholmes at openjdk.org
Mon Jul 31 04:53:40 UTC 2023


On Mon, 31 Jul 2023 04:40:58 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> https://bugs.openjdk.org/browse/JDK-8313374
>> --enable-ccache's CCACHE_BASEDIR breaks builds
>
> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Try not to remove CCACHE_BASEDIR.

make/autoconf/build-performance.m4 line 246:

> 244:     fi
> 245: 
> 246:     if $ALLOW_ABSOLUTE_PATHS_IN_OUTPUT;then

Does this even build? Surely you need `if test ...` here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15080#discussion_r1278790633



More information about the build-dev mailing list