RFR: 8313374: --enable-ccache's CCACHE_BASEDIR breaks builds [v2]

[David Holmes]

On Mon, 31 Jul 2023 05:02:35 GMT, Jan Kratochvil <jkratochvil at openjdk.org> wrote:

>> make/autoconf/build-performance.m4 line 246:
>> 
>>> 244:     fi
>>> 245: 
>>> 246:     if $ALLOW_ABSOLUTE_PATHS_IN_OUTPUT;then
>> 
>> Does this even build? Surely you need `if test ...` here?
>
> It works fine, I did test it.
> 
> make/autoconf/jdk-options.m4:    ALLOW_ABSOLUTE_PATHS_IN_OUTPUT="false"
> make/autoconf/jdk-options.m4:    ALLOW_ABSOLUTE_PATHS_IN_OUTPUT="true"
> make/autoconf/jdk-options.m4:    ALLOW_ABSOLUTE_PATHS_IN_OUTPUT="false"
> make/autoconf/jdk-options.m4:    ALLOW_ABSOLUTE_PATHS_IN_OUTPUT="true"
> 
> I see other code is using the test:
> 
> make/autoconf/flags-cflags.m4:    if test "x$ALLOW_ABSOLUTE_PATHS_IN_OUTPUT" = "xfalse"; then
> 
> So I will change it.

Yes please always use the existing style in the build files - we know that they work correctly everywhere, whereas other approaches may not.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15080#discussion_r1278799034