RFR: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM [v2]

Gerard Ziemski gziemski at openjdk.org
Thu Jun 1 15:45:22 UTC 2023


On Wed, 31 May 2023 23:01:54 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> > You have chosen to use an OS independent mechanism, at the cost of exposing the implementation to the outside world, >by introducing a new stage (needs CSR).
>> 
>> That is not an accurate characterisation of this change. The CSR request is needed because of the change in behaviour it introduces (by only returning a fully initialized VM), and has nothing at all to do with the implementation. We still need to be able to distinguish when VM creation has started (to prevent concurrent attempt) and when it has completed (so GetCreatedJavaVMs can return a valid VM) - the mechanism by which that is achieved is immaterial.

Sorry, I should have read https://bugs.openjdk.org/browse/JDK-8308816 instead of assuming the impact of this change on the outside.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14139#issuecomment-1572295716



More information about the build-dev mailing list