RFR: 8308969: make test-prebuilt doesn't return the correct exit code [v2]

Erik Joelsson erikj at openjdk.org
Fri Jun 2 20:51:06 UTC 2023


On Fri, 2 Jun 2023 18:40:22 GMT, Antonios Printezis <tonyp at openjdk.org> wrote:

>> For 'make' test and 'make test-only' the existence of exit-with-error is checked in the main target in Init.gmk. Is there a better way to fix this than to check for the existence of exit-with-error in RunTestsPrebuilt.gmk?
>
> Antonios Printezis has updated the pull request incrementally with one additional commit since the last revision:
> 
>   changes based on code review feedback

I'm ok with this solution.

make/Global.gmk line 135:

> 133: # Alias for backwards compatibility
> 134: run-test-prebuilt: test-prebuilt
> 135: run-test-prebuilt-with-exit-code: test-prebuilt-with-exit-code

I don't think we need this alias since this is a new target.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14183#pullrequestreview-1458460785
PR Review Comment: https://git.openjdk.org/jdk/pull/14183#discussion_r1214824528



More information about the build-dev mailing list