RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v11]

Alexander Zvegintsev azvegint at openjdk.org
Wed Jun 7 10:36:20 UTC 2023


On Wed, 7 Jun 2023 05:40:38 GMT, Phil Race <prr at openjdk.org> wrote:

>> src/java.desktop/unix/classes/sun/awt/screencast/TokenStorage.java line 145:
>> 
>>> 143:                     path,
>>> 144:                     Set.of(PosixFilePermission.OWNER_READ,
>>> 145:                             PosixFilePermission.OWNER_WRITE)
>> 
>> alignment issue..Posix..OWNER_WRITE should be placed below Posix..OENER_READ
>> 
>> Also, why we aren't adding OWNER_EXECUTE here too like done above?
>
> Because execute is required on directories but not files unless they are programs.

Exactly, without an execute bit on the directory we cannot access/add/remove its files.

Our file is not a script or executable that needs to be run.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13803#discussion_r1221327703



More information about the build-dev mailing list