RFR: JDK-8307314: Implementation: Generational Shenandoah (Experimental) [v9]

[Kelvin Nilsen]

On Wed, 7 Jun 2023 07:54:17 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update copyright notices
>
> src/hotspot/share/gc/shenandoah/shenandoahFullGC.hpp line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 2014, 2021, Red Hat, Inc. All rights reserved.
>> 3:  * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
> 
> Unnecessary

fixed.

> src/hotspot/share/gc/shenandoah/shenandoahGC.cpp line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 2021, Red Hat, Inc. All rights reserved.
>> 3:  * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
> 
> Unnecessary

fixed.

> src/hotspot/share/gc/shenandoah/shenandoahGC.hpp line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 2021, Red Hat, Inc. All rights reserved.
>> 3:  * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
> 
> Unnecessary

fixed.

> src/hotspot/share/gc/shenandoah/shenandoahNMethod.cpp line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 2019, 2022, Red Hat, Inc. All rights reserved.
>> 3:  * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
> 
> Unnecessary?

fixed.

> src/hotspot/share/gc/shenandoah/shenandoahNumberSeq.hpp line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 2018, 2019, Red Hat, Inc. All rights reserved.
>> 3:  * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
> 
> Unnecessary?

fixed.

> src/hotspot/share/gc/shenandoah/shenandoahSTWMark.hpp line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 2021, Red Hat, Inc. All rights reserved.
>> 3:  * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
> 
> unnecessary.

fixed.

> src/hotspot/share/gc/shenandoah/shenandoahUnload.cpp line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 2019, 2021, Red Hat, Inc. All rights reserved.
>> 3:  * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
> 
> Delete

fixed.

> src/hotspot/share/gc/shenandoah/shenandoahWorkerPolicy.cpp line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 2017, 2019, Red Hat, Inc. All rights reserved.
>> 3:  * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
> 
> Unnecessary

fixed.

> src/hotspot/share/gc/shenandoah/shenandoahWorkerPolicy.hpp line 3:
> 
>> 1: /*
>> 2:  * Copyright (c) 2017, 2022, Red Hat, Inc. All rights reserved.
>> 3:  * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
> 
> Unnecessary

fixed.

> test/hotspot/gtest/gc/shenandoah/test_shenandoahNumberSeq.cpp line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights reserved.
> 
> This may be deleted as far as I can tell, or we can just leave it in there.

will leave as is.

> test/hotspot/jtreg/gc/stress/gcold/TestGCOldWithShenandoah.java line 3:
> 
>> 1: /*
>> 2: * Copyright (c) 2016, 2020, Oracle and/or its affiliates. All rights reserved.
>> 3: * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
> 
> General comment: Looking at the history, I might have expected RedHat copyright headers also for many of these tests, but that isn't a change that's happened with generational shenandoah. So, nothing for us to do in this PR.

ok.  will leave as is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221595485
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221596525
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221597200
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221597834
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221598462
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221599944
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221599533
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221600615
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221601596
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221602442
PR Review Comment: https://git.openjdk.org/jdk/pull/14185#discussion_r1221604163