RFR: 8307858: [REDO] JDK-8307194 Add make target for optionally building a complete set of all JDK and hotspot libjvm static libraries [v7]

Jiangli Zhou jiangli at openjdk.org
Fri Jun 9 23:04:33 UTC 2023


On Fri, 9 Jun 2023 20:03:23 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> All our builds succeeded, so this is looking pretty good now. Just a minor suggestion left.

Thanks a lot!

> This combination of conditions is repeated 3 times. Maybe we could assign the result to a variable (e.g. `$1_ENABLE_PARTIAL_LINKING`) and check for that instead?

Done, thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14064#issuecomment-1585213568
PR Review Comment: https://git.openjdk.org/jdk/pull/14064#discussion_r1224866324



More information about the build-dev mailing list