RFR: 8307527: MacOS Zero builds fail with undefined FFI_GO_CLOSURES after JDK-8304265 [v2]

[Jorn Vernee]

On Mon, 8 May 2023 10:18:35 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> See the bug. Actually, I am not sure why JDK-8304265 changed the `#ifndef FFI_GO_CLOSURES` to `#ifdef _APPLE_`. That seems too intrusive if `FFI_GO_CLOSURES` *is* enabled. So I rewrote the block to something more safe.
>> 
>> Additional testing:
>>  - [x] macos-aarch64-zero-fastdebug `make images` passes
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use a build system fix

Coming back to this: It looks like your check works if I put it right after the `AC_LINK_IFELSE` use in `lib-ffi.m4`, but before the `CFLAGS` and `LIBS` are reset.

I have been looking at this script as well to get it working on mac and windows: https://github.com/openjdk/jdk/compare/master...JornVernee:jdk:LibFFI_Mac_Win (I have it working on both those platforms)

If you're not able to test, I could also take your fix and create a PR for the patch I have with your fix included (and add you as a contributor). WDYT?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13827#issuecomment-1588295956