RFR: 8309468: Remove jvmti Allocate locker test case

David Holmes dholmes at openjdk.org
Tue Jun 13 02:22:40 UTC 2023


On Mon, 12 Jun 2023 16:39:12 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

> There is a bunch of tests that are used to test critical section/gc locker. One of the test is named jvmti locker. In that test, JNI code is doing a loop of ` jvmti->Allocate()` followed `sleep()` followed by a `jvmti->Deallocate()`. There is no JVM lock implementation to be tested on jvmti Allocate/Deallocate, they are implemented using malloc/free. Let us save test time, code complexity and confusion by removing this test. 
> 
> This removal is very similar to https://bugs.openjdk.org/browse/JDK-8309048
> 
> (Oracle) hs-tier5 testing passed on x86-64.

Serviceability folk should probably look at this and @lmesnik.

I can't see what this is actually trying to test either, so removing it seems fine to me too.

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14421#pullrequestreview-1476125547



More information about the build-dev mailing list