RFR: JDK-8310321: make JDKOPT_CHECK_CODESIGN_PARAMS more verbose

[Erik Joelsson]

On Tue, 20 Jun 2023 12:00:05 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Hi Erik, the added codesign tool calls are already printed into the rather verbose config.log. In the main configure output we see only what we saw before
> 
> checking for macosx code signing mode... auto, default checking for macosx code signing identity... openjdk_codesign, default checking if codesign with hardened runtime is possible... no checking if debug mode codesign is possible... no checking for macosx code signing mode... disabled

With your patch, configure.log and my console has this output:


checking for macosx code signing identity... openjdk_codesign, default
configure: check codesign, calling /usr/bin/codesign -s - /Users/erik/dev/jdk/build/macosx-aarch64-debug/configure-support/codesign-testfile
checking if debug mode codesign is possible... yes
checking for macosx code signing mode... debug


I think printing the command line used to probe codesign fits in config.log but not in the console output. This is the model used by the builtin macros in autoconf, such as probing for compiler flags. You can achieve this by something like:

echo $CODESIGN $PARAMS $CODESIGN_TESTFILE > $AS_MESSAGE_LOG_FD

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14541#issuecomment-1598705628