RFR: 8294982: Implementation of Classfile API [v58]

[Adam Sotona]

On Fri, 23 Jun 2023 09:05:21 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed obsolete javadoc from implementation classes
>
> src/java.base/share/classes/jdk/internal/classfile/instruction/ConstantInstruction.java line 139:
> 
>> 137:         Util.checkKind(op, Opcode.Kind.CONSTANT);
>> 138:         if (op != Opcode.BIPUSH && op != Opcode.SIPUSH)
>> 139:             throw new IllegalArgumentException(String.format("Wrong opcode specified; found %s, expected BIPUSH or SIPUSH", op, op.kind()));
> 
> IDEA shows warning here.
> Too many arguments for format string (found: 2, expected: 1)
> 
> Seems op.kind() parameter is unused in the format string.
> 
> And the same issue in `jdk.internal.classfile.instruction.ConstantInstruction#ofLoad`

I'll fix it, thank you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10982#discussion_r1241816908