RFR: 8294982: Implementation of Classfile API [v20]

Adam Sotona asotona at openjdk.org
Wed Mar 1 09:53:34 UTC 2023


On Thu, 16 Feb 2023 11:34:28 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   added 4-byte Unicode text to Utf8EntryTest
>
> src/java.base/share/classes/jdk/internal/classfile/components/package-info.java line 97:
> 
>> 95:  * {@snippet lang="java" class="PackageSnippets" region="classInstrumentation"}
>> 96:  */
>> 97: package jdk.internal.classfile.components;
> 
> watch out for newline

fixed, thanks.

> src/java.base/share/classes/jdk/internal/classfile/impl/TargetInfoImpl.java line 34:
> 
>> 32: 
>> 33: /**
>> 34:  *
> 
> Empty javadoc?

fixed, thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/10982



More information about the build-dev mailing list