RFR: 8302659: Modernize Windows native code for NetworkInterface [v3]

Rich DiCroce duke at openjdk.org
Wed Mar 1 14:37:57 UTC 2023


On Thu, 23 Feb 2023 11:50:54 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Rich DiCroce has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Forgot to add file
>>  - Resolve review comments
>
> src/java.base/windows/native/libnet/NetworkInterface.c line 295:
> 
>> 293:     apiRetVal = GetIfEntry2(ifRow);
>> 294:     if (apiRetVal != NO_ERROR) {
>> 295:         if (throwIfNotFound && apiRetVal == ERROR_FILE_NOT_FOUND) {
> 
> Suggestion:
> 
>         if (throwIfNotFound || apiRetVal != ERROR_FILE_NOT_FOUND) {

Since there were no cases left where throwIfNotFound was true, I have removed it altogether.

-------------

PR: https://git.openjdk.org/jdk/pull/12593



More information about the build-dev mailing list