RFR: 8303355: The Depend plugin does fully recompile when primitive type changes [v2]

Jan Lahoda jlahoda at openjdk.org
Wed Mar 1 19:01:16 UTC 2023


On Wed, 1 Mar 2023 11:09:17 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adjusting DependTest, as suggested on the review
>
> make/jdk/src/classes/build/tools/depend/Depend.java line 885:
> 
>> 883:         @Override
>> 884:         public Void visitPrimitiveType(PrimitiveTypeTree node, Void p) {
>> 885:             update(node.getPrimitiveTypeKind().name());
> 
> shouldn't `DependTest` include a test to stress this new code?

Test updated:
https://github.com/openjdk/jdk/pull/12801/commits/de84439d64f6882d64f657fee0f6c55b2f717a9c

Thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/12801



More information about the build-dev mailing list