RFR: 8294982: Implementation of Classfile API [v13]

[Paul Sandoz]

On Wed, 8 Feb 2023 11:00:14 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/classfile/attribute/StackMapTableAttribute.java line 68:
>> 
>>> 66:      * A simple stack value.
>>> 67:      */
>>> 68:     public enum SimpleVerificationTypeInfo implements VerificationTypeInfo {
>> 
>> I note that in this class we have made the decision to model all the innards (XYZInfo) as nested classes - while in all the other cases XYZInfo are toplevel types. Moving forward, we should pick something consistent.
>
> Every case has been considered individually, evaluated on use cases and pros and cons have been weighted. Unified approach across the whole API would be nice, however not so simple and not the highest priority.

I had the same observation as Maurizio.

-------------

PR: https://git.openjdk.org/jdk/pull/10982