RFR: 8294982: Implementation of Classfile API [v36]

[Paul Sandoz]

On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> This is root pull request with Classfile API implementation, tests and benchmarks initial drop into JDK.
>> 
>> Following pull requests consolidating JDK class files parsing, generating, and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) will chain to this one.
>> 
>> Classfile API development is tracked at:
>> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-branch
>> 
>> Development branch of consolidated JDK class files parsing, generating, and transforming is at:
>> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-dev-branch
>> 
>> Classfile API [JEP](https://bugs.openjdk.org/browse/JDK-8280389) and [online API documentation](https://htmlpreview.github.io/?https://raw.githubusercontent.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/java.base/jdk/internal/classfile/package-summary.html) is also available.
>> 
>> Please take you time to review this non-trivial JDK addition.
>> 
>> Thank you,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   StackMapFrameInfo extracted to top level from StackMapTableAttribute

src/java.base/share/classes/jdk/internal/classfile/instruction/ConstantInstruction.java line 41:

> 39:  * Models a constant-load instruction in the {@code code} array of a {@code
> 40:  * Code} attribute, including "intrinsic constant" instructions (e.g., {@code
> 41:  * aload_0}), "argument constant" instructions (e.g., {@code bipush}), and "load

Suggestion:

 * iconst_0}), "argument constant" instructions (e.g., {@code bipush}), and "load

Otherwise we can refer to `aconst_null`

src/java.base/share/classes/jdk/internal/classfile/instruction/ConstantInstruction.java line 60:

> 58:     /**
> 59:      * Models an "intrinsic constant" instruction (e.g., {@code
> 60:      * aload_0}).

Suggestion:

     * iconst_0}).

-------------

PR: https://git.openjdk.org/jdk/pull/10982