RFR: 8294982: Implementation of Classfile API [v36]

[Paul Sandoz]

On Thu, 2 Mar 2023 14:31:06 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> This is root pull request with Classfile API implementation, tests and benchmarks initial drop into JDK.
>> 
>> Following pull requests consolidating JDK class files parsing, generating, and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) will chain to this one.
>> 
>> Classfile API development is tracked at:
>> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-branch
>> 
>> Development branch of consolidated JDK class files parsing, generating, and transforming is at:
>> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-dev-branch
>> 
>> Classfile API [JEP](https://bugs.openjdk.org/browse/JDK-8280389) and [online API documentation](https://htmlpreview.github.io/?https://raw.githubusercontent.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/java.base/jdk/internal/classfile/package-summary.html) is also available.
>> 
>> Please take you time to review this non-trivial JDK addition.
>> 
>> Thank you,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   StackMapFrameInfo extracted to top level from StackMapTableAttribute

src/java.base/share/classes/jdk/internal/classfile/instruction/LoadInstruction.java line 66:

> 64:      * @param slot the local varaible slot to load from
> 65:      */
> 66:     static LoadInstruction of(Opcode op, int slot) {

Should you validate that `slot` is compatible with `op`? (same for the StoreInstruction?)

src/java.base/share/classes/jdk/internal/classfile/instruction/NewObjectInstruction.java line 38:

> 36:  * of a {@link CodeModel}.
> 37:  */
> 38: public sealed interface NewObjectInstruction extends Instruction

Should we add a helper method on `CodeBuilder` that does the new + dup + invoke special <init> dance?

-------------

PR: https://git.openjdk.org/jdk/pull/10982