RFR: JDK-8302801: Remove fdlibm C sources [v3]

Joe Darcy darcy at openjdk.org
Fri Mar 3 02:10:15 UTC 2023


On Fri, 3 Mar 2023 01:02:40 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> Hotspot changes are okay but I'm a bit confused about what the hotspot code will now be used for?

I'm not 100% positive if the current __kernel_rem_pio2 code would be in use. IIRC, back when we used the fsin/fcos instructions to intrinsify sin/cos on the x87 FPU, to meet Java semantics we needed to do argument reduction into the range supported by fsin/fcos. Perhaps  __kernel_rem_pio2 is a hold-over from that time? I believe my recent sin/cos algorithms for instrincs wouldn't need to use these pathways.

-------------

PR: https://git.openjdk.org/jdk/pull/12821



More information about the build-dev mailing list