RFR: 8286781: Replace the deprecated/obsolete gethostbyname and inet_addr calls [v2]
Daniel Jeliński
djelinski at openjdk.org
Fri Mar 3 11:23:14 UTC 2023
On Fri, 3 Mar 2023 09:56:35 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> We can replace `gethostbyname`, which is deprecated on Windows and Linux, with `getaddrinfo`. This API is available on all supported platforms and so can be placed in shared code. @djelinski pointed out that `getaddrinfo` can resolve both IP addresses and host names so the two step approach used in `networkStream::connect` is not necessary and we can do away with `os::get_host_by_name()` completely.
>>
>> The build is updated to enable winsock deprecation warnings, and now we need to use `ws2_32.lib` we can drop `wsock32.lib` (as it is basically a subset - again thanks @djelinski ).
>>
>> Testing
>> - all Oracle builds in tiers 1-5
>> - All GHA builds
>>
>> The actual code change has to be manually tested because the code is only used by Ideal Graph Printing to connect to the Ideal Graph Visualizer. I've manually tested on Windows and Linux and @tobiasholenstein tested macOS.
>>
>> Thanks.
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>
> Restrict getaddrinfo to IPv4 only as per the rest of the code
Marked as reviewed by djelinski (Committer).
-------------
PR: https://git.openjdk.org/jdk/pull/12842
More information about the build-dev
mailing list