RFR: 8294982: Implementation of Classfile API [v41]

[Adam Sotona]

On Fri, 3 Mar 2023 14:14:55 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Signature.TypeArg does not inherit from Signature
>
> src/java.base/share/classes/jdk/internal/classfile/AccessFlags.java line 54:
> 
>> 52:      * {@return whether the specified flag is present}  The specified flag
>> 53:      * should be a valid flag for the classfile location associated with this
>> 54:      * element.
> 
> Hello Adam, the way this is worded, it feels like if the flag isn't valid then this method would raise an exception. Looking at the implementation, that doesn't look like the case. Should it be reworded to say it returns false in such cases?
> 
> On a related note, since this JEP is for introducing this API for internal use only, would you prefer if the javadoc text isn't reviewed to this level of detail?

I'll fix it, thanks for the review. 
Manageable amount of javadoc comments is OK, preferably with directly proposed patches :)

-------------

PR: https://git.openjdk.org/jdk/pull/10982