RFR: 8294982: Implementation of Classfile API [v36]

[Adam Sotona]

On Fri, 3 Mar 2023 00:57:35 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   StackMapFrameInfo extracted to top level from StackMapTableAttribute
>
> src/java.base/share/classes/jdk/internal/classfile/impl/AbstractDirectBuilder.java line 34:
> 
>> 32:  * AbstractDirectBuilder
>> 33:  */
>> 34: public class AbstractDirectBuilder<B, M> {
> 
> Type variable `B` is unused.

fixed, thanks.

> src/java.base/share/classes/jdk/internal/classfile/impl/TransformImpl.java line 63:
> 
>> 61:     private static final Runnable NOTHING = () -> { };
>> 62: 
>> 63:     interface FakeClassTransform extends ClassTransform {
> 
> Rename to `UnresolvedXxxTransform`? I think that is a better name, since it could appear in stack traces. Like with `XxxTransformImpl` it may be possible to share across all implementations by mixing in?

Renamed to `UnresolvedXyzTransform`, thanks.
I'll consider conversion to generic form in a next step.

-------------

PR: https://git.openjdk.org/jdk/pull/10982