RFR: 8294982: Implementation of Classfile API [v43]

[Paul Sandoz]

On Fri, 3 Mar 2023 16:39:41 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> This is root pull request with Classfile API implementation, tests and benchmarks initial drop into JDK.
>> 
>> Following pull requests consolidating JDK class files parsing, generating, and transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) will chain to this one.
>> 
>> Classfile API development is tracked at:
>> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-branch
>> 
>> Development branch of consolidated JDK class files parsing, generating, and transforming is at:
>> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-dev-branch
>> 
>> Classfile API [JEP](https://bugs.openjdk.org/browse/JDK-8280389) and [online API documentation](https://htmlpreview.github.io/?https://raw.githubusercontent.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/java.base/jdk/internal/classfile/package-summary.html) is also available.
>> 
>> Please take you time to review this non-trivial JDK addition.
>> 
>> Thank you,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - fixed AccessFlags javadoc
>  - TransformImpl.FakeXyzTransform renamed to UnresolvedXyzTransform
>  - removed obsolete generic parameter from AbstractDirectBuilder

src/java.base/share/classes/jdk/internal/classfile/impl/AttributeHolder.java line 73:

> 71:             if (a.attributeMapper() == am)
> 72:                 iterator.remove();
> 73:         }

Suggestion:

    attributes.removeIf(a -> a.attributeMappter() == am);

But presumably use an inner class instead. I can understand because of that if you want to keep the existing code instead.

src/java.base/share/classes/jdk/internal/classfile/impl/AttributeHolder.java line 76:

> 74:     }
> 75: 
> 76:     List<? extends Attribute<?>> attributes() {

Unused

-------------

PR: https://git.openjdk.org/jdk/pull/10982