RFR: 8302189: Mark assertion failures noreturn [v2]

[Julian Waters]

On Sat, 4 Mar 2023 11:16:03 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> make/hotspot/lib/CompileJvm.gmk line 103:
>> 
>>> 101: DISABLED_WARNINGS_xlc := tautological-compare shift-negative-value
>>> 102: 
>>> 103: DISABLED_WARNINGS_microsoft := 4624 4244 4291 4146 4127 4722
>> 
>> It is annoying that we don't document what these warnings are. :(
>
> I've made the same comment in the past.  This time I decided to do something about it:
> https://bugs.openjdk.org/browse/JDK-8303618
> Document disabled C/C++ warnings on Windows

Looks like something I can help with, will assign the enhancement to myself

>> src/hotspot/share/utilities/debug.cpp line 290:
>> 
>>> 288:  private:
>>> 289:   ResourceMark _rm;
>>> 290:   DebuggingContext _debugging;
>> 
>> Why a different initialization syntax here?
>
> I don't understand the question?  These are member variable declarations.

I believe David is asking about why these particular member names were changed

-------------

PR: https://git.openjdk.org/jdk/pull/12845