RFR: 8294982: Implementation of Classfile API [v43]
Adam Sotona
asotona at openjdk.org
Mon Mar 6 13:23:02 UTC 2023
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
----------------------------------------------------------------------
On Fri, 3 Mar 2023 23:12:17 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - fixed AccessFlags javadoc
>> - TransformImpl.FakeXyzTransform renamed to UnresolvedXyzTransform
>> - removed obsolete generic parameter from AbstractDirectBuilder
>
> src/java.base/share/classes/jdk/internal/classfile/impl/Util.java line 161:
>
>> 159: var desc = cd.descriptorString();
>> 160: return switch (desc.charAt(0)) {
>> 161: case '[' -> desc;
>
> Is this correct? Arrays don't have an internal name.
It is a workaround to get CP class entry name string from descriptor, so the `toInternalName` is not exact.
I'll handle the array descriptors separately and let this method to handle real class internal names only.
-------------
PR: https://git.openjdk.org/jdk/pull/10982
More information about the build-dev
mailing list