RFR: 8294982: Implementation of Classfile API [v43]

Adam Sotona asotona at openjdk.org
Mon Mar 6 14:06:41 UTC 2023


On Fri, 3 Mar 2023 22:35:48 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - fixed AccessFlags javadoc
>>  - TransformImpl.FakeXyzTransform renamed to UnresolvedXyzTransform
>>  - removed obsolete generic parameter from AbstractDirectBuilder
>
> src/java.base/share/classes/jdk/internal/classfile/impl/CodeImpl.java line 52:
> 
>> 50:     static final Instruction[] SINGLETON_INSTRUCTIONS = new Instruction[256];
>> 51: 
>> 52:     static {
> 
> Can we loop through all `Opcode` values filter for `sizeIfFixed == 1` and switch on the kind? If so that would avoid the need for explicit lists and simplify the code.

Yes, that is good idea.
Fixed, thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/10982



More information about the build-dev mailing list