RFR: 8302189: Mark assertion failures noreturn [v2]

[David Holmes]

On Sat, 4 Mar 2023 11:16:10 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> src/hotspot/share/utilities/debug.cpp line 85:
>> 
>>> 83:   if (is_enabled()) {
>>> 84:     fatal("Multiple Debugging contexts");
>>> 85:   }
>> 
>> This seems too restrictive as you could hit different DebuggingContexts in different threads. ??
>
> This facility is only intended for use by manually invoked commands while the program is stopped in a debugger. Multi-threaded use is not an issue (and was not supported previously either). I don't think there are any nested uses either, but I've now run across a couple of places where nesting could be useful. So I'm changing the state from a simple bool to a nesting counter.

Okay I hadn't realized the process was basically "suspended" when this was activated - as I said I never use this stuff.

-------------

PR: https://git.openjdk.org/jdk/pull/12845