RFR: 8303485: Replacing os.name for operating system customization

Mandy Chung mchung at openjdk.org
Thu Mar 9 17:06:30 UTC 2023


The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.

----------------------------------------------------------------------
On Thu, 9 Mar 2023 16:03:37 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> I would argue that we should keep the replacement string matching the make variable its getting the value from. It makes it easier to trace the origin of the value. 
>> 
>> Using the terms `CURRENT` or `TARGET` inside the java class is less clear. `TARGET` is a references to how the JDK was built while `CURRENT` is more of a reference to the current runtime. Both are correct, it's more about what mental model we want at this level.
>
> The symbol has to match the build usage of OPENJDK_TARGET_OS, not the name.

The one in the template file is independent to the build variables.

-------------

PR: https://git.openjdk.org/jdk/pull/12931



More information about the build-dev mailing list