RFR: 8303485: Replacing os.name for operating system customization
David Holmes
dholmes at openjdk.org
Fri Mar 10 02:48:20 UTC 2023
The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.
----------------------------------------------------------------------
On Thu, 9 Mar 2023 16:12:26 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> src/java.base/share/classes/jdk/internal/misc/OperatingSystem.java line 105:
>>
>>> 103: */
>>> 104: @ForceInline
>>> 105: public static boolean isMac() {
>>
>> suggestion: isMacOS
>
> As above, sticking to a generic term can make this a bit less sensitive to branding changes.
Lets at least be consistent and not introduce a rage of terms. "mac" is a piece of hardware.
-------------
PR: https://git.openjdk.org/jdk/pull/12931
More information about the build-dev
mailing list